Commit 5800db81 authored Apr 06, 2018 by David Howells

afs: Init inode before accessing cache



We no longer parse symlinks when we get the inode to determine if this
symlink is actually a mountpoint as we detect that by examining the mode
instead (symlinks are always 0777 and mountpoints 0644).

Access the cache after mapping the status so that we don't have to manually
set the inode size now.

Note that this may need adjusting if the disconnected operation is
implemented as the file metadata may have to be obtained from the cache.

Signed-off-by: David Howells <dhowells@redhat.com>

parent d55b4da4

fs/afs/inode.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -331,15 +331,12 @@ struct inode afs_iget(struct super_block sb, struct key *key,
		vnode->cb_expires_at += ktime_get_real_seconds();
		}

		/* set up caching before mapping the status, as map-status reads the
		* first page of symlinks to see if they're really mountpoints */
		inode->i_size = vnode->status.size;
		afs_get_inode_cache(vnode);

		ret = afs_inode_map_status(vnode, key);
		if (ret < 0)
		goto bad_inode;

		afs_get_inode_cache(vnode);

		/* success */
		clear_bit(AFS_VNODE_UNSET, &vnode->flags);
		inode->i_flags \|= S_NOATIME;

Admin message