Commit 57d4f0b8 authored Sep 16, 2019 by Omar Sandoval Committed by David Sterba Nov 18, 2019

btrfs: don't prematurely free work in scrub_missing_raid56_worker()



Currently, scrub_missing_raid56_worker() puts and potentially frees
sblock (which embeds the work item) and then submits a bio through
scrub_wr_submit(). This is another potential instance of the bug in
"btrfs: don't prematurely free work in run_ordered_work()". Fix it by
dropping the reference after we submit the bio.

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Omar Sandoval <osandov@fb.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent e732fe95

fs/btrfs/scrub.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -2149,14 +2149,13 @@ static void scrub_missing_raid56_worker(struct btrfs_work *work)
		scrub_write_block_to_dev_replace(sblock);
		}

		scrub_block_put(sblock);

		if (sctx->is_dev_replace && sctx->flush_all_writes) {
		mutex_lock(&sctx->wr_lock);
		scrub_wr_submit(sctx);
		mutex_unlock(&sctx->wr_lock);
		}

		scrub_block_put(sblock);
		scrub_pending_bio_dec(sctx);
		}

Admin message