staging: wlan-ng: Remove function hfa384x_dowrid_async() (57d100b8) · Commits · 戴 / test

Remove function hfa384x_dowrid_async as it does nothing except call hfa384x_dowrid, and itself is called only once. Move the contents of hfa384x_dowrid_async (i.e the call to hfa384x_dowrid) to its call site. Issue found with Coccinelle. Signed-off-by:

Nishka Dasgupta <nishkadg.linux@gmail.com> Link: https://lore.kernel.org/r/20190712062807.9361-3-nishkadg.linux@gmail.com Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/wlan-ng/hfa384x_usb.c

+2 −13

Original line number	Diff line number	Diff line
		@@ -845,17 +845,6 @@ hfa384x_dorrid_async(struct hfa384x *hw,
		cmdcb, usercb, usercb_data);
		}

		static inline int
		hfa384x_dowrid_async(struct hfa384x *hw,
		u16 rid, void *riddata, unsigned int riddatalen,
		ctlx_cmdcb_t cmdcb,
		ctlx_usercb_t usercb, void *usercb_data)
		{
		return hfa384x_dowrid(hw, DOASYNC,
		rid, riddata, riddatalen,
		cmdcb, usercb, usercb_data);
		}

		static inline int
		hfa384x_dormem_wait(struct hfa384x *hw,
		u16 page, u16 offset, void *data, unsigned int len)
		@@ -2078,8 +2067,8 @@ hfa384x_drvr_setconfig_async(struct hfa384x *hw,
		void *buf,
		u16 len, ctlx_usercb_t usercb, void *usercb_data)
		{
		return hfa384x_dowrid_async(hw, rid, buf, len,
		hfa384x_cb_status, usercb, usercb_data);
		return hfa384x_dowrid(hw, DOASYNC, rid, buf, len, hfa384x_cb_status,
		usercb, usercb_data);
		}

		/*----------------------------------------------------------------

Admin message