Commit 57ca7deb authored Aug 04, 2009 by Anders Grafström Committed by David Woodhouse Aug 04, 2009

jffs2: Fix return value from jffs2_do_readpage_nolock()



This fixes "kernel BUG at fs/jffs2/file.c:251!".
This pseudocode hopefully illustrates the scenario that triggers it:

jffs2_write_begin {
     jffs2_do_readpage_nolock {
         jffs2_read_inode_range {
             jffs2_read_dnode {
                 Data CRC 33c102e9 != calculated CRC 0ef77e7b for node at 005d42e4
                 return -EIO;
             }
         }
         ClearPageUptodate(pg);
         return 0;
     }
}

jffs2_write_end {
     BUG_ON(!PageUptodate(pg));
}

Signed-off-by: Anders Grafström <grfstrm@users.sourceforge.net>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

parent d676c117

fs/jffs2/file.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -99,7 +99,7 @@ static int jffs2_do_readpage_nolock (struct inode inode, struct page pg)
		kunmap(pg);

		D2(printk(KERN_DEBUG "readpage finished\n"));
		return 0;
		return ret;
		}

		int jffs2_do_readpage_unlock(struct inode inode, struct page pg)

Admin message