nfsd4: CREATE_SESSION should update backchannel immediately (57a37144) · Commits · 戴 / test

nfsd4_probe_callback kicks off some work that will eventually run nfsd4_process_cb_update and update the session flags. In theory we could process a following SEQUENCE call before that update happens resulting in flags that don't accurately represent, for example, the lack of a backchannel. Signed-off-by:

J. Bruce Fields <bfields@redhat.com>

fs/nfsd/nfs4state.c

+2 −4

Original line number	Original line	Diff line number	Diff line
	@@ -1223,10 +1223,8 @@ static void nfsd4_init_conn(struct svc_rqst rqstp, struct nfsd4_conn conn, str
	if (ret)		if (ret)
	/* oops; xprt is already down: */		/* oops; xprt is already down: */
	nfsd4_conn_lost(&conn->cn_xpt_user);		nfsd4_conn_lost(&conn->cn_xpt_user);
	if (conn->cn_flags & NFS4_CDFC4_BACK) {		/* We may have gained or lost a callback channel: */
	/* callback channel may be back up */		nfsd4_probe_callback_sync(ses->se_client);
	nfsd4_probe_callback(ses->se_client);
	}
	}		}

	static struct nfsd4_conn alloc_conn_from_crses(struct svc_rqst rqstp, struct nfsd4_create_session *cses)		static struct nfsd4_conn alloc_conn_from_crses(struct svc_rqst rqstp, struct nfsd4_create_session *cses)

Admin message