Commit 578c03c8 authored Jan 16, 2014 by Namhyung Kim Committed by Arnaldo Carvalho de Melo Jan 21, 2014

perf symbols: Fix JIT symbol resolution on heap



Gaurav reported that perf cannot profile JIT program if it executes the
code on heap.  This was because current map__new() only handle JIT on
anon mappings - extends it to handle no_dso (heap, stack) case too.

This patch assumes JIT profiling only provides dynamic function symbols
so check the mapping type to distinguish the case.  It'd provide no
symbols for data mapping - if we need to support symbols on data
mappings later it should be changed.

Reported-by: Gaurav Jain <gjain@fb.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: Gaurav Jain <gjain@fb.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Gaurav Jain <gjain@fb.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1389836971-3549-1-git-send-email-namhyung@kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 8ad9219e

tools/perf/util/map.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -69,7 +69,7 @@ struct map map__new(struct list_head dsos__list, u64 start, u64 len,
		map->ino = ino;
		map->ino_generation = ino_gen;

		if (anon) {
		if ((anon \|\| no_dso) && type == MAP__FUNCTION) {
		snprintf(newfilename, sizeof(newfilename), "/tmp/perf-%d.map", pid);
		filename = newfilename;
		}
		@@ -93,7 +93,7 @@ struct map map__new(struct list_head dsos__list, u64 start, u64 len,
		* functions still return NULL, and we avoid the
		* unnecessary map__load warning.
		*/
		if (no_dso)
		if (type != MAP__FUNCTION)
		dso__set_loaded(dso, map->type);
		}
		}

Admin message