sparc: mm: return true,false in kern_addr_valid() (57829ea4) · Commits · 戴 / test

This function's return type is bool and returns both true/false and 0/1. This fixes the following coccicheck warning: arch/sparc/mm/init_64.c:1652:9-10: WARNING: return of 0/1 in function 'kern_addr_valid' with return type bool Signed-off-by:

Jason Yan <yanaijie@huawei.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

arch/sparc/mm/init_64.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -1674,29 +1674,29 @@ bool kern_addr_valid(unsigned long addr)

		pgd = pgd_offset_k(addr);
		if (pgd_none(*pgd))
		return 0;
		return false;

		p4d = p4d_offset(pgd, addr);
		if (p4d_none(*p4d))
		return 0;
		return false;

		pud = pud_offset(p4d, addr);
		if (pud_none(*pud))
		return 0;
		return false;

		if (pud_large(*pud))
		return pfn_valid(pud_pfn(*pud));

		pmd = pmd_offset(pud, addr);
		if (pmd_none(*pmd))
		return 0;
		return false;

		if (pmd_large(*pmd))
		return pfn_valid(pmd_pfn(*pmd));

		pte = pte_offset_kernel(pmd, addr);
		if (pte_none(*pte))
		return 0;
		return false;

		return pfn_valid(pte_pfn(*pte));
		}

Admin message