Commit 573671a5 authored Dec 22, 2018 by Dan Carpenter Committed by Jason Gunthorpe Dec 22, 2018

IB/uverbs: Signedness bug in UVERBS_HANDLER()



The "num_sge" variable needs to be signed for the error handling to work.
The uverbs_attr_ptr_get_array_size() returns int so this change is safe.

Fixes: ad8a4496 ("IB/uverbs: Add support to advise_mr")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent aa74be6e

drivers/infiniband/core/uverbs_std_types_mr.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -47,7 +47,7 @@ static int UVERBS_HANDLER(UVERBS_METHOD_ADVISE_MR)(
		enum ib_uverbs_advise_mr_advice advice;
		struct ib_device *ib_dev = pd->device;
		struct ib_sge *sg_list;
		u32 num_sge;
		int num_sge;
		u32 flags;
		int ret;

Admin message