Commit 57274ea2 authored May 21, 2019 by Lu Baolu Committed by Joerg Roedel May 27, 2019

iommu: Use right function to get group for device



The iommu_group_get_for_dev() will allocate a group for a
device if it isn't in any group. This isn't the use case
in iommu_request_dm_for_dev(). Let's use iommu_group_get()
instead.

Fixes: d290f1e7 ("iommu: Introduce iommu_request_dm_for_dev()")
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>

parent cd6c84d8

drivers/iommu/iommu.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1915,9 +1915,9 @@ int iommu_request_dm_for_dev(struct device *dev)
		int ret;

		/* Device must already be in a group before calling this function */
		group = iommu_group_get_for_dev(dev);
		if (IS_ERR(group))
		return PTR_ERR(group);
		group = iommu_group_get(dev);
		if (!group)
		return -EINVAL;

		mutex_lock(&group->mutex);

Admin message