Commit 57208632 authored Aug 02, 2018 by Michael Kelley Committed by Greg Kroah-Hartman Aug 02, 2018

Drivers: hv: vmbus: Cleanup synic memory free path



clk_evt memory is not being freed when the synic is shutdown
or when there is an allocation error.  Add the appropriate
kfree() call, along with a comment to clarify how the memory
gets freed after an allocation error.  Make the free path
consistent by removing checks for NULL since kfree() and
free_page() already do the check.

Signed-off-by: Michael Kelley <mikelley@microsoft.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6ba34171

drivers/hv/hv.c

+8 −6

Original line number	Diff line number	Diff line
		@@ -242,6 +242,10 @@ int hv_synic_alloc(void)

		return 0;
		err:
		/*
		* Any memory allocations that succeeded will be freed when
		* the caller cleans up by calling hv_synic_free()
		*/
		return -ENOMEM;
		}

		@@ -254,11 +258,9 @@ void hv_synic_free(void)
		struct hv_per_cpu_context *hv_cpu
		= per_cpu_ptr(hv_context.cpu_context, cpu);

		if (hv_cpu->synic_event_page)
		kfree(hv_cpu->clk_evt);
		free_page((unsigned long)hv_cpu->synic_event_page);
		if (hv_cpu->synic_message_page)
		free_page((unsigned long)hv_cpu->synic_message_page);
		if (hv_cpu->post_msg_page)
		free_page((unsigned long)hv_cpu->post_msg_page);
		}

Admin message