Commit 571ff473 authored Jul 02, 2014 by Ian Kent Committed by Linus Torvalds Jul 03, 2014

autofs4: fix false positive compile error



On strict build environments we can see:

  fs/autofs4/inode.c: In function 'autofs4_fill_super':
  fs/autofs4/inode.c:312: error: 'pgrp' may be used uninitialized in this function
  make[2]: *** [fs/autofs4/inode.o] Error 1
  make[1]: *** [fs/autofs4] Error 2
  make: *** [fs] Error 2
  make: *** Waiting for unfinished jobs....

This is due to the use of pgrp_set being used to indicate pgrp has has
been set rather than initializing pgrp itself.

Signed-off-by: Ian Kent <raven@themaw.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 8a5b20ae

fs/autofs4/inode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -210,7 +210,7 @@ int autofs4_fill_super(struct super_block s, void data, int silent)
		int pipefd;
		struct autofs_sb_info *sbi;
		struct autofs_info *ino;
		int pgrp;
		int pgrp = 0;
		bool pgrp_set = false;
		int ret = -EINVAL;

Admin message