Commit 571fae6e authored by Martijn Coenen's avatar Martijn Coenen Committed by Jens Axboe
Browse files

loop: Rework lo_ioctl() __user argument casting 



In preparation for a new ioctl that needs to copy_from_user(); makes the
code easier to read as well.

Signed-off-by: default avatarMartijn Coenen <maco@android.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 62ab466c

drivers/block/loop.c

+5 −6
Original line number Diff line number Diff line
@@ -1634,6 +1634,7 @@ static int lo_ioctl(struct block_device *bdev, fmode_t mode, 
	unsigned int cmd, unsigned long arg)

{

	struct loop_device *lo = bdev->bd_disk->private_data;

	void __user *argp = (void __user *) arg;

	int err;



	switch (cmd) {
@@ -1646,21 +1647,19 @@ static int lo_ioctl(struct block_device *bdev, fmode_t mode, 
	case LOOP_SET_STATUS:

		err = -EPERM;

		if ((mode & FMODE_WRITE) || capable(CAP_SYS_ADMIN)) {

			err = loop_set_status_old(lo,

					(struct loop_info __user *)arg);

			err = loop_set_status_old(lo, argp);

		}

		break;

	case LOOP_GET_STATUS:

		return loop_get_status_old(lo, (struct loop_info __user *) arg);

		return loop_get_status_old(lo, argp);

	case LOOP_SET_STATUS64:

		err = -EPERM;

		if ((mode & FMODE_WRITE) || capable(CAP_SYS_ADMIN)) {

			err = loop_set_status64(lo,

					(struct loop_info64 __user *) arg);

			err = loop_set_status64(lo, argp);

		}

		break;

	case LOOP_GET_STATUS64:

		return loop_get_status64(lo, (struct loop_info64 __user *) arg);

		return loop_get_status64(lo, argp);

	case LOOP_SET_CAPACITY:

	case LOOP_SET_DIRECT_IO:

	case LOOP_SET_BLOCK_SIZE:

CRA Git | Maintained and supported by SUSTech CRA and CCSE