Commit 571e4121 authored by Alan Stern's avatar Alan Stern Committed by Greg Kroah-Hartman
Browse files

USB: remove iteration limit in hub_tt_work() 



This patch (as1621) removes the limit on the number of loops allowed
in hub_tt_work().  The value is arbitrary, and it's silly to have a
limit in the first place -- anything beyond the limit would not get
handled.

Besides, it's most unlikely that we'll ever need to clear more than a
couple of TT buffers at any time.

Signed-off-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bcbec053

drivers/usb/core/hub.c

+0 −4
Original line number Diff line number Diff line
@@ -741,7 +741,6 @@ static void hub_tt_work(struct work_struct *work) 
	struct usb_hub		*hub =

		container_of(work, struct usb_hub, tt.clear_work);

	unsigned long		flags;

	int			limit = 100;



	spin_lock_irqsave (&hub->tt.lock, flags);

	while (!list_empty(&hub->tt.clear_list)) {
@@ -751,9 +750,6 @@ static void hub_tt_work(struct work_struct *work) 
		const struct hc_driver	*drv;

		int			status;



		if (!hub->quiescing && --limit < 0)

			break;



		next = hub->tt.clear_list.next;

		clear = list_entry (next, struct usb_tt_clear, clear_list);

		list_del (&clear->clear_list);

CRA Git | Maintained and supported by SUSTech CRA and CCSE