Commit 571e3f3a authored Dec 03, 2017 by Guenter Roeck

hwmon: (w83773g) Fix fault detection and reporting



Smatch reports:

drivers/hwmon/w83773g.c:105
	get_fault() warn: shift has higher precedence than mask

Code analysis shows that the code is indeed wrong.
Fix it, and while we are at it, drop unnecessary typecast.

Fixes: 86a10c802362 ("hwmon: Add W83773G driver")
Cc: Lei YU <mine260309@gmail.com>
Reviewed-by: Lei YU <mine260309@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent a7a9b15a

drivers/hwmon/w83773g.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -102,7 +102,7 @@ static int get_fault(struct regmap regmap, int index, long val)
		if (ret < 0)
		return ret;

		*val = (u8)regval & 0x04 >> 2;
		*val = (regval & 0x04) >> 2;
		return 0;
		}

Admin message