Commit 57176601 authored Nov 27, 2018 by Adrian Hunter Committed by Arnaldo Carvalho de Melo Dec 18, 2018

perf auxtrace: Alter addr_filter__entire_dso() to work if there are no symbols



addr_filter__entire_dso() uses the first and last symbols from a dso,
and so does not work when there are no symbols.  Alter it to filter the
whole file instead.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Fixes: 1b36c03e ("perf record: Add support for using symbols in address filters")
Link: http://lkml.kernel.org/r/20181127084634.12469-1-adrian.hunter@intel.com


[ split from a larger patch ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent b5c2161c

tools/perf/util/auxtrace.c

+4 −7

Original line number	Diff line number	Diff line
		@@ -1983,17 +1983,14 @@ static int find_dso_sym(struct dso dso, const char sym_name, u64 *start,

		static int addr_filter__entire_dso(struct addr_filter filt, struct dso dso)
		{
		struct symbol *first_sym = dso__first_symbol(dso);
		struct symbol *last_sym = dso__last_symbol(dso);

		if (!first_sym \|\| !last_sym) {
		pr_err("Failed to determine filter for %s\nNo symbols found.\n",
		if (dso__data_file_size(dso, NULL)) {
		pr_err("Failed to determine filter for %s\nCannot determine file size.\n",
		filt->filename);
		return -EINVAL;
		}

		filt->addr = first_sym->start;
		filt->size = last_sym->end - first_sym->start;
		filt->addr = 0;
		filt->size = dso->data.file_size;

		return 0;
		}

Admin message