Commit 570ac933 authored Jan 20, 2016 by Oleg Nesterov Committed by Linus Torvalds Jan 20, 2016

ptrace: task_stopped_code(ptrace => true) can't see TASK_STOPPED task



task_stopped_code()->task_is_stopped_or_traced() doesn't look right, the
traced task must never be TASK_STOPPED.

We can not add WARN_ON(task_is_stopped(p)), but this is only because
do_wait() can race with PTRACE_ATTACH from another thread.

[akpm@linux-foundation.org: teeny cleanup]
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Roland McGrath <roland@hack.frob.com>
Acked-by: Tejun Heo <tj@kernel.org>
Cc: Pedro Alves <palves@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 7c3b00e0

kernel/exit.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1120,8 +1120,7 @@ static int wait_task_zombie(struct wait_opts wo, struct task_struct p)
		static int task_stopped_code(struct task_struct p, bool ptrace)
		{
		if (ptrace) {
		if (task_is_stopped_or_traced(p) &&
		!(p->jobctl & JOBCTL_LISTENING))
		if (task_is_traced(p) && !(p->jobctl & JOBCTL_LISTENING))
		return &p->exit_code;
		} else {
		if (p->signal->flags & SIGNAL_STOP_STOPPED)

Admin message