Commit 56d282d9 authored Apr 12, 2019 by Marc Dionne Committed by David S. Miller Apr 12, 2019

rxrpc: Clear socket error



When an ICMP or ICMPV6 error is received, the error will be attached
to the socket (sk_err) and the report function will get called.
Clear any pending error here by calling sock_error().

This would cause the following attempt to use the socket to fail with
the error code stored by the ICMP error, resulting in unexpected errors
with various side effects depending on the context.

Signed-off-by: Marc Dionne <marc.dionne@auristor.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Tested-by: Jonathan Billings <jsbillin@umich.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1dc2b3d6

net/rxrpc/peer_event.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -157,6 +157,11 @@ void rxrpc_error_report(struct sock *sk)

		_enter("%p{%d}", sk, local->debug_id);

		/* Clear the outstanding error value on the socket so that it doesn't
		* cause kernel_sendmsg() to return it later.
		*/
		sock_error(sk);

		skb = sock_dequeue_err_skb(sk);
		if (!skb) {
		_leave("UDP socket errqueue empty");

Admin message