Commit 56d1d674 authored Jul 06, 2020 by Laurent Pinchart Committed by Mauro Carvalho Chehab Jul 19, 2020

media: ti-vpe: cal: Remove unneeded phy->sensor NULL check



The phy->sensor NULL check in cal_camerarx_get_external_rate() is not
needed, as the V4L2 video devices are only registered when the sensor is
bound. Remove it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Benoit Parrot <bparrot@ti.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

parent 399b0a3d

drivers/media/platform/ti-vpe/cal.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -485,9 +485,6 @@ static s64 cal_camerarx_get_external_rate(struct cal_camerarx *phy)
		struct v4l2_ctrl *ctrl;
		s64 rate;

		if (!phy->sensor)
		return -ENODEV;

		ctrl = v4l2_ctrl_find(phy->sensor->ctrl_handler, V4L2_CID_PIXEL_RATE);
		if (!ctrl) {
		phy_err(phy, "no pixel rate control in subdev: %s\n",

Admin message