dmaengine: stm32-mdma: driver defers probe for clock and reset (56cf8dda) · Commits · 戴 / test

This patch changes error log when failing to get the clock so that it is not printed on failure with probe deferring. It also defers probe when reset controller is expected but has not been probed yet when MDMA device is probed. Signed-off-by:

Etienne Carriere <etienne.carriere@st.com> Signed-off-by:

Amelie Delaunay <amelie.delaunay@st.com> Link: https://lore.kernel.org/r/20200127085334.13163-5-amelie.delaunay@st.com Signed-off-by:

Vinod Koul <vkoul@kernel.org>

drivers/dma/stm32-mdma.c

+7 −3

Original line number	Diff line number	Diff line
		@@ -1579,8 +1579,8 @@ static int stm32_mdma_probe(struct platform_device *pdev)
		dmadev->clk = devm_clk_get(&pdev->dev, NULL);
		if (IS_ERR(dmadev->clk)) {
		ret = PTR_ERR(dmadev->clk);
		if (ret == -EPROBE_DEFER)
		dev_info(&pdev->dev, "Missing controller clock\n");
		if (ret != -EPROBE_DEFER)
		dev_err(&pdev->dev, "Missing clock controller\n");
		return ret;
		}

		@@ -1591,7 +1591,11 @@ static int stm32_mdma_probe(struct platform_device *pdev)
		}

		rst = devm_reset_control_get(&pdev->dev, NULL);
		if (!IS_ERR(rst)) {
		if (IS_ERR(rst)) {
		ret = PTR_ERR(rst);
		if (ret == -EPROBE_DEFER)
		goto err_clk;
		} else {
		reset_control_assert(rst);
		udelay(2);
		reset_control_deassert(rst);

Admin message