Commit 56c09de3 authored Jun 18, 2020 by Sabrina Dubroca Committed by David S. Miller Jun 19, 2020

geneve: allow changing DF behavior after creation



Currently, trying to change the DF parameter of a geneve device does
nothing:

    # ip -d link show geneve1
    14: geneve1: <snip>
        link/ether <snip>
        geneve id 1 remote 10.0.0.1 ttl auto df set dstport 6081 <snip>
    # ip link set geneve1 type geneve id 1 df unset
    # ip -d link show geneve1
    14: geneve1: <snip>
        link/ether <snip>
        geneve id 1 remote 10.0.0.1 ttl auto df set dstport 6081 <snip>

We just need to update the value in geneve_changelink.

Fixes: a025fb5f ("geneve: Allow configuration of DF behaviour")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9deba33f

drivers/net/geneve.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1649,6 +1649,7 @@ static int geneve_changelink(struct net_device dev, struct nlattr tb[],
		geneve->collect_md = metadata;
		geneve->use_udp6_rx_checksums = use_udp6_rx_checksums;
		geneve->ttl_inherit = ttl_inherit;
		geneve->df = df;
		geneve_unquiesce(geneve, gs4, gs6);

		return 0;

Admin message