Commit 569e0f35 authored by Josef Bacik's avatar Josef Bacik
Browse files

Btrfs: place ordered operations on a per transaction list 



Miao made the ordered operations stuff run async, which introduced a
deadlock where we could get somebody (sync) racing in and committing the
transaction while a commit was already happening.  The new committer would
try and flush ordered operations which would hang waiting for the commit to
finish because it is done asynchronously and no longer inherits the callers
trans handle.  To fix this we need to make the ordered operations list a per
transaction list.  We can get new inodes added to the ordered operation list
by truncating them and then having another process writing to them, so this
makes it so that anybody trying to add an ordered operation _must_ start a
transaction in order to add itself to the list, which will keep new inodes
from getting added to the ordered operations list after we start committing.
This should fix the deadlock and also keeps us from doing a lot more work
than we need to during commit.  Thanks,

Signed-off-by: default avatarJosef Bacik <jbacik@fusionio.com>
parent dde5740f

fs/btrfs/ctree.h

+0 −7
Original line number Diff line number Diff line
@@ -1407,13 +1407,6 @@ struct btrfs_fs_info { 
	 */

	struct list_head delalloc_inodes;



	/*

	 * special rename and truncate targets that must be on disk before

	 * we're allowed to commit.  This is basically the ext3 style

	 * data=ordered list.

	 */

	struct list_head ordered_operations;



	/*

	 * there is a pool of worker threads for checksumming during writes

	 * and a pool for checksumming after reads.  This is because readers

fs/btrfs/disk-io.c

+6 −5
Original line number Diff line number Diff line
@@ -56,7 +56,8 @@ static void end_workqueue_fn(struct btrfs_work *work); 
static void free_fs_root(struct btrfs_root *root);

static int btrfs_check_super_valid(struct btrfs_fs_info *fs_info,

				    int read_only);

static void btrfs_destroy_ordered_operations(struct btrfs_root *root);

static void btrfs_destroy_ordered_operations(struct btrfs_transaction *t,

					     struct btrfs_root *root);

static void btrfs_destroy_ordered_extents(struct btrfs_root *root);

static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,

				      struct btrfs_root *root);
@@ -2029,7 +2030,6 @@ int open_ctree(struct super_block *sb, 
	INIT_LIST_HEAD(&fs_info->dead_roots);

	INIT_LIST_HEAD(&fs_info->delayed_iputs);

	INIT_LIST_HEAD(&fs_info->delalloc_inodes);

	INIT_LIST_HEAD(&fs_info->ordered_operations);

	INIT_LIST_HEAD(&fs_info->caching_block_groups);

	spin_lock_init(&fs_info->delalloc_lock);

	spin_lock_init(&fs_info->trans_lock);
@@ -3538,7 +3538,8 @@ void btrfs_error_commit_super(struct btrfs_root *root) 
	btrfs_cleanup_transaction(root);

}



static void btrfs_destroy_ordered_operations(struct btrfs_root *root)

static void btrfs_destroy_ordered_operations(struct btrfs_transaction *t,

					     struct btrfs_root *root)

{

	struct btrfs_inode *btrfs_inode;

	struct list_head splice;
@@ -3548,7 +3549,7 @@ static void btrfs_destroy_ordered_operations(struct btrfs_root *root) 
	mutex_lock(&root->fs_info->ordered_operations_mutex);

	spin_lock(&root->fs_info->ordered_extent_lock);



	list_splice_init(&root->fs_info->ordered_operations, &splice);

	list_splice_init(&t->ordered_operations, &splice);

	while (!list_empty(&splice)) {

		btrfs_inode = list_entry(splice.next, struct btrfs_inode,

					 ordered_operations);
@@ -3829,7 +3830,7 @@ int btrfs_cleanup_transaction(struct btrfs_root *root) 
	while (!list_empty(&list)) {

		t = list_entry(list.next, struct btrfs_transaction, list);



		btrfs_destroy_ordered_operations(root);

		btrfs_destroy_ordered_operations(t, root);



		btrfs_destroy_ordered_extents(root);

fs/btrfs/file.c

+14 −1
Original line number Diff line number Diff line
@@ -1628,7 +1628,20 @@ int btrfs_release_file(struct inode *inode, struct file *filp) 
	 */

	if (test_and_clear_bit(BTRFS_INODE_ORDERED_DATA_CLOSE,

			       &BTRFS_I(inode)->runtime_flags)) {

		btrfs_add_ordered_operation(NULL, BTRFS_I(inode)->root, inode);

		struct btrfs_trans_handle *trans;

		struct btrfs_root *root = BTRFS_I(inode)->root;



		/*

		 * We need to block on a committing transaction to keep us from

		 * throwing a ordered operation on to the list and causing

		 * something like sync to deadlock trying to flush out this

		 * inode.

		 */

		trans = btrfs_start_transaction(root, 0);

		if (IS_ERR(trans))

			return PTR_ERR(trans);

		btrfs_add_ordered_operation(trans, BTRFS_I(inode)->root, inode);

		btrfs_end_transaction(trans, root);

		if (inode->i_size > BTRFS_ORDERED_OPERATIONS_FLUSH_LIMIT)

			filemap_flush(inode->i_mapping);

	}

fs/btrfs/ordered-data.c

+8 −5
Original line number Diff line number Diff line
@@ -612,10 +612,12 @@ void btrfs_wait_ordered_extents(struct btrfs_root *root, int delay_iput) 
 * extra check to make sure the ordered operation list really is empty

 * before we return

 */

int btrfs_run_ordered_operations(struct btrfs_root *root, int wait)

int btrfs_run_ordered_operations(struct btrfs_trans_handle *trans,

				 struct btrfs_root *root, int wait)

{

	struct btrfs_inode *btrfs_inode;

	struct inode *inode;

	struct btrfs_transaction *cur_trans = trans->transaction;

	struct list_head splice;

	struct list_head works;

	struct btrfs_delalloc_work *work, *next;
@@ -626,7 +628,7 @@ int btrfs_run_ordered_operations(struct btrfs_root *root, int wait) 


	mutex_lock(&root->fs_info->ordered_operations_mutex);

	spin_lock(&root->fs_info->ordered_extent_lock);

	list_splice_init(&root->fs_info->ordered_operations, &splice);

	list_splice_init(&cur_trans->ordered_operations, &splice);

	while (!list_empty(&splice)) {

		btrfs_inode = list_entry(splice.next, struct btrfs_inode,

				   ordered_operations);
@@ -643,7 +645,7 @@ int btrfs_run_ordered_operations(struct btrfs_root *root, int wait) 


		if (!wait)

			list_add_tail(&BTRFS_I(inode)->ordered_operations,

				      &root->fs_info->ordered_operations);

				      &cur_trans->ordered_operations);

		spin_unlock(&root->fs_info->ordered_extent_lock);



		work = btrfs_alloc_delalloc_work(inode, wait, 1);
@@ -653,7 +655,7 @@ int btrfs_run_ordered_operations(struct btrfs_root *root, int wait) 
				list_add_tail(&btrfs_inode->ordered_operations,

					      &splice);

			list_splice_tail(&splice,

					 &root->fs_info->ordered_operations);

					 &cur_trans->ordered_operations);

			spin_unlock(&root->fs_info->ordered_extent_lock);

			ret = -ENOMEM;

			goto out;
@@ -1033,6 +1035,7 @@ out: 
void btrfs_add_ordered_operation(struct btrfs_trans_handle *trans,

				 struct btrfs_root *root, struct inode *inode)

{

	struct btrfs_transaction *cur_trans = trans->transaction;

	u64 last_mod;



	last_mod = max(BTRFS_I(inode)->generation, BTRFS_I(inode)->last_trans);
@@ -1047,7 +1050,7 @@ void btrfs_add_ordered_operation(struct btrfs_trans_handle *trans, 
	spin_lock(&root->fs_info->ordered_extent_lock);

	if (list_empty(&BTRFS_I(inode)->ordered_operations)) {

		list_add_tail(&BTRFS_I(inode)->ordered_operations,

			      &root->fs_info->ordered_operations);

			      &cur_trans->ordered_operations);

	}

	spin_unlock(&root->fs_info->ordered_extent_lock);

}

fs/btrfs/ordered-data.h

+2 −1
Original line number Diff line number Diff line
@@ -197,7 +197,8 @@ struct btrfs_ordered_extent *btrfs_lookup_ordered_range(struct inode *inode, 
int btrfs_ordered_update_i_size(struct inode *inode, u64 offset,

				struct btrfs_ordered_extent *ordered);

int btrfs_find_ordered_sum(struct inode *inode, u64 offset, u64 disk_bytenr, u32 *sum);

int btrfs_run_ordered_operations(struct btrfs_root *root, int wait);

int btrfs_run_ordered_operations(struct btrfs_trans_handle *trans,

				 struct btrfs_root *root, int wait);

void btrfs_add_ordered_operation(struct btrfs_trans_handle *trans,

				 struct btrfs_root *root,

				 struct inode *inode);

CRA Git | Maintained and supported by SUSTech CRA and CCSE