Commit 569bc643 authored May 15, 2018 by Ursula Braun Committed by David S. Miller May 16, 2018

net/smc: no tx work trigger for fallback sockets



If TCP_NODELAY is set or TCP_CORK is reset, setsockopt triggers the
tx worker. This does not make sense, if the SMC socket switched to
the TCP fallback when the connection is created. This patch adds
the additional check for the fallback case.

Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7d6541fb

net/smc/af_smc.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1353,14 +1353,14 @@ static int smc_setsockopt(struct socket *sock, int level, int optname,
		break;
		case TCP_NODELAY:
		if (sk->sk_state != SMC_INIT && sk->sk_state != SMC_LISTEN) {
		if (val)
		if (val && !smc->use_fallback)
		mod_delayed_work(system_wq, &smc->conn.tx_work,
		0);
		}
		break;
		case TCP_CORK:
		if (sk->sk_state != SMC_INIT && sk->sk_state != SMC_LISTEN) {
		if (!val)
		if (!val && !smc->use_fallback)
		mod_delayed_work(system_wq, &smc->conn.tx_work,
		0);
		}

Admin message