Commit 569b7892 authored Jan 07, 2010 by Mark Brown Committed by David S. Miller Jan 07, 2010

cs89x0: Always report failure to request interrupt



A failure on request_irq() is always fatal but unlike other fatal
errors it's only reported to the user if net_debug is set. Make the
diagnostic unconditional and raise the priority so that errors are
more obvious to the user.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8a5c9c49

drivers/net/cs89x0.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1325,8 +1325,7 @@ net_open(struct net_device *dev)
		write_irq(dev, lp->chip_type, dev->irq);
		ret = request_irq(dev->irq, net_interrupt, 0, dev->name, dev);
		if (ret) {
		if (net_debug)
		printk(KERN_DEBUG "cs89x0: request_irq(%d) failed\n", dev->irq);
		printk(KERN_ERR "cs89x0: request_irq(%d) failed\n", dev->irq);
		goto bad_out;
		}
		}

Admin message