Commit 5698d2c9 authored Jul 17, 2013 by Namhyung Kim Committed by Arnaldo Carvalho de Melo Jul 17, 2013

perf symbols: Do not apply symfs for an absolute vmlinux path



If an user gives both of --symfs and --vmlinux option, the vmlinux will
be searched under the symfs directory.  This is somewhat confusing since
vmlinux often lives in kernel build directory or somewhere other than
user space binaries.

So it'd be better not adding symfs prefix for a vmlinux if it has an
absolute pathname.

Reported-by: Kwanghyun Yoo <ykh815.yoo@lge.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: David Ahern <dsahern@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1374048495-3643-1-git-send-email-namhyung@kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent ab4ecda5

tools/perf/util/symbol.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -888,6 +888,9 @@ int dso__load_vmlinux(struct dso dso, struct map map,
		char symfs_vmlinux[PATH_MAX];
		enum dso_binary_type symtab_type;

		if (vmlinux[0] == '/')
		snprintf(symfs_vmlinux, sizeof(symfs_vmlinux), "%s", vmlinux);
		else
		snprintf(symfs_vmlinux, sizeof(symfs_vmlinux), "%s%s",
		symbol_conf.symfs, vmlinux);

Admin message