Commit 56917766 authored Feb 20, 2020 by Tariq Toukan Committed by Saeed Mahameed Mar 05, 2020

net/mlx5e: kTLS, Fix TCP seq off-by-1 issue in TX resync flow



We have an off-by-1 issue in the TCP seq comparison.
The last sequence number that belongs to the TCP packet's payload
is not "start_seq + len", but one byte before it.
Fix it so the 'ends_before' is evaluated properly.

This fixes a bug that results in error completions in the
kTLS HW offload flows.

Fixes: ffbd9ca9 ("net/mlx5e: kTLS, Fix corner-case checks in TX resync flow")
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Reviewed-by: Boris Pismenny <borisp@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

parent 692b0399

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -218,7 +218,7 @@ tx_sync_info_get(struct mlx5e_ktls_offload_context_tx *priv_tx,
		* this packet was already acknowledged and its record info
		* was released.
		*/
		ends_before = before(tcp_seq + datalen, tls_record_start_seq(record));
		ends_before = before(tcp_seq + datalen - 1, tls_record_start_seq(record));

		if (unlikely(tls_record_is_start_marker(record))) {
		ret = ends_before ? MLX5E_KTLS_SYNC_SKIP_NO_DATA : MLX5E_KTLS_SYNC_FAIL;

Admin message