Commit 5674a92c authored Mar 28, 2019 by Dan Carpenter Committed by Li Yang Apr 02, 2019

soc/fsl/qe: Fix an error code in qe_pin_request()



We forgot to set "err" on this error path.

Fixes: 1a2d397a ("gpio/powerpc: Eliminate duplication of of_get_named_gpio_flags()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Li Yang <leoyang.li@nxp.com>

parent 9e98c678

drivers/soc/fsl/qe/gpio.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -179,8 +179,10 @@ struct qe_pin qe_pin_request(struct device_node np, int index)
		if (err < 0)
		goto err0;
		gc = gpio_to_chip(err);
		if (WARN_ON(!gc))
		if (WARN_ON(!gc)) {
		err = -ENODEV;
		goto err0;
		}

		if (!of_device_is_compatible(gc->of_node, "fsl,mpc8323-qe-pario-bank")) {
		pr_debug("%s: tried to get a non-qe pin\n", __func__);

Admin message