Commit 566aacaf authored by Mao Wenan's avatar Mao Wenan Committed by Felipe Balbi
Browse files

usb: udc: lpc32xx: remove set but not used 3 variables 



Fixes gcc '-Wunused-but-set-variable' warning:
drivers/usb/gadget/udc/lpc32xx_udc.c: In function ‘udc_protocol_cmd_r’:
drivers/usb/gadget/udc/lpc32xx_udc.c:744:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable]

drivers/usb/gadget/udc/lpc32xx_udc.c: In function ‘udc_handle_dma_ep’:
drivers/usb/gadget/udc/lpc32xx_udc.c:1994:14: warning: variable ‘epstatus’ set but not used [-Wunused-but-set-variable]

drivers/usb/gadget/udc/lpc32xx_udc.c: In function ‘udc_handle_ep0_setup’:
drivers/usb/gadget/udc/lpc32xx_udc.c:2200:22: warning: variable ‘wLength’ set but not used [-Wunused-but-set-variable]

It is not used since commit 90fccb52 ("usb: gadget: Gadget directory cleanup - group UDC drivers")

Signed-off-by: default avatarMao Wenan <maowenan@huawei.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 163be6ff

drivers/usb/gadget/udc/lpc32xx_udc.c

+3 −6
Original line number Diff line number Diff line
@@ -742,7 +742,6 @@ static inline void udc_protocol_cmd_data_w(struct lpc32xx_udc *udc, u32 cmd, 
 * response data */

static u32 udc_protocol_cmd_r(struct lpc32xx_udc *udc, u32 cmd)

{

	u32 tmp;

	int to = 1000;



	/* Write a command and read data from the protocol engine */
@@ -752,7 +751,6 @@ static u32 udc_protocol_cmd_r(struct lpc32xx_udc *udc, u32 cmd) 
	/* Write command code */

	udc_protocol_cmd_w(udc, cmd);



	tmp = readl(USBD_DEVINTST(udc->udp_baseaddr));

	while ((!(readl(USBD_DEVINTST(udc->udp_baseaddr)) & USBD_CDFULL))

	       && (to > 0))

		to--;
@@ -1992,7 +1990,7 @@ void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) 
/* DMA end of transfer completion */

static void udc_handle_dma_ep(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)

{

	u32 status, epstatus;

	u32 status;

	struct lpc32xx_request *req;

	struct lpc32xx_usbd_dd_gad *dd;
@@ -2086,7 +2084,7 @@ static void udc_handle_dma_ep(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) 
		if (udc_clearep_getsts(udc, ep->hwep_num) & EP_SEL_F) {

			udc_clearep_getsts(udc, ep->hwep_num);

			uda_enable_hwepint(udc, ep->hwep_num);

			epstatus = udc_clearep_getsts(udc, ep->hwep_num);

			udc_clearep_getsts(udc, ep->hwep_num);



			/* Let the EP interrupt handle the ZLP */

			return;
@@ -2198,7 +2196,7 @@ static void udc_handle_ep0_setup(struct lpc32xx_udc *udc) 
	struct lpc32xx_ep *ep, *ep0 = &udc->ep[0];

	struct usb_ctrlrequest ctrlpkt;

	int i, bytes;

	u16 wIndex, wValue, wLength, reqtype, req, tmp;

	u16 wIndex, wValue, reqtype, req, tmp;



	/* Nuke previous transfers */

	nuke(ep0, -EPROTO);
@@ -2214,7 +2212,6 @@ static void udc_handle_ep0_setup(struct lpc32xx_udc *udc) 
	/* Native endianness */

	wIndex = le16_to_cpu(ctrlpkt.wIndex);

	wValue = le16_to_cpu(ctrlpkt.wValue);

	wLength = le16_to_cpu(ctrlpkt.wLength);

	reqtype = le16_to_cpu(ctrlpkt.bRequestType);



	/* Set direction of EP0 */

CRA Git | Maintained and supported by SUSTech CRA and CCSE