Commit 565ce8f3 authored Jun 27, 2016 by Nikolay Aleksandrov Committed by David S. Miller Jun 29, 2016

net: bridge: fix vlan stats continue counter



I made a dumb off-by-one mistake when I added the vlan stats counter
dumping code. The increment should happen before the check, not after
otherwise we miss one entry when we continue dumping.

Fixes: a60c0903 ("bridge: netlink: export per-vlan stats")
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a3d2e9f8

net/bridge/br_netlink.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1273,7 +1273,7 @@ static int br_fill_linkxstats(struct sk_buff skb, const struct net_device dev,
		struct bridge_vlan_xstats vxi;
		struct br_vlan_stats stats;

		if (vl_idx++ < *prividx)
		if (++vl_idx < *prividx)
		continue;
		memset(&vxi, 0, sizeof(vxi));
		vxi.vid = v->vid;

Admin message