Commit 5654699f authored Aug 27, 2014 by Johan Hovold Committed by Greg Kroah-Hartman Aug 27, 2014

USB: serial: fix potential heap buffer overflow



Make sure to verify the number of ports requested by subdriver to avoid
writing beyond the end of fixed-size array in interface data.

The current usb-serial implementation is limited to eight ports per
interface but failed to verify that the number of ports requested by a
subdriver (which could have been determined from device descriptors) did
not exceed this limit.

Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d979e9f9

drivers/usb/serial/usb-serial.c

+5 −0

Original line number	Original line	Diff line number	Diff line
	@@ -862,6 +862,11 @@ static int usb_serial_probe(struct usb_interface *interface,
	num_ports = type->num_ports;		num_ports = type->num_ports;
	}		}

			if (num_ports > MAX_NUM_PORTS) {
			dev_warn(ddev, "too many ports requested: %d\n", num_ports);
			num_ports = MAX_NUM_PORTS;
			}

	serial->num_ports = num_ports;		serial->num_ports = num_ports;
	serial->num_bulk_in = num_bulk_in;		serial->num_bulk_in = num_bulk_in;
	serial->num_bulk_out = num_bulk_out;		serial->num_bulk_out = num_bulk_out;

Admin message