x86: add DMI quirk for AMI BIOS which corrupts address 0xc000 during resume (5649b7c3) · Commits · 戴 / test

Alan Jenkins and Andy Wettstein reported a suspend/resume memory corruption bug and extensively documented it here: http://bugzilla.kernel.org/show_bug.cgi?id=11237 The bug is that the BIOS overwrites 1K of memory at 0xc000 physical, without registering it in e820 as reserved or giving the kernel any idea about this. Detect AMI BIOSen and reserve that 1K. We paint this bug around with a very broad brush (reserving that 1K on all AMI BIOS systems), as the bug was extremely hard to find and needed several weeks and lots of debugging and patching. The bug was found via the CONFIG_X86_CHECK_BIOS_CORRUPTION=y debug feature, if similar bugs are suspected then this feature can be enabled on other systems as well to scan low memory for corrupted memory. Reported-by:

Alan Jenkins <alan-jenkins@tuffmail.co.uk> Reported-by:

Andy Wettstein <ajw1980@gmail.com> Signed-off-by:

Ingo Molnar <mingo@elte.hu>

arch/x86/kernel/setup.c

+27 −0

Original line number	Diff line number	Diff line
		@@ -729,6 +729,29 @@ void start_periodic_check_for_corruption(void)
		}
		#endif

		static int __init dmi_low_memory_corruption(const struct dmi_system_id *d)
		{
		printk(KERN_NOTICE
		"%s detected: BIOS corrupts 0xc000, working it around.\n",
		d->ident);

		reserve_early(0xc000, 0xc400, "BIOS quirk");

		return 0;
		}

		/* List of systems that have known low memory corruption BIOS problems */
		static struct dmi_system_id __initdata bad_bios_dmi_table[] = {
		{
		.callback = dmi_low_memory_corruption,
		.ident = "AMI BIOS",
		.matches = {
		DMI_MATCH(DMI_BIOS_VENDOR, "American Megatrends Inc."),
		},
		},
		{}
		};

		/*
		* Determine if we were loaded by an EFI loader. If so, then we have also been
		* passed the efi memmap, systab, etc., so we should use these data structures
		@@ -752,6 +775,8 @@ void __init setup_arch(char **cmdline_p)
		printk(KERN_INFO "Command line: %s\n", boot_command_line);
		#endif

		dmi_check_system(bad_bios_dmi_table);

		early_cpu_init();
		early_ioremap_init();

		@@ -1037,3 +1062,5 @@ void __init setup_arch(char **cmdline_p)
		#endif
		#endif
		}

Admin message