Commit 56450c20 authored Aug 26, 2020 by Jens Axboe

io_uring: clear req->result on IOPOLL re-issue



Make sure we clear req->result, which was set to -EAGAIN for retry
purposes, when moving it to the reissue list. Otherwise we can end up
retrying a request more than once, which leads to weird results in
the io-wq handling (and other spots).

Cc: stable@vger.kernel.org
Reported-by: Andres Freund <andres@anarazel.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 0fef9483

fs/io_uring.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2049,6 +2049,7 @@ static void io_iopoll_complete(struct io_ring_ctx ctx, unsigned int nr_events,

		req = list_first_entry(done, struct io_kiocb, inflight_entry);
		if (READ_ONCE(req->result) == -EAGAIN) {
		req->result = 0;
		req->iopoll_completed = 0;
		list_move_tail(&req->inflight_entry, &again);
		continue;

Admin message