pstore/platform: Switch pstore_info::name to const (563ca40d) · Commits · 戴 / test

In order to more cleanly pass around backend names, make the "name" member const. This means the module param needs to be dynamic (technically, it was before, so this actually cleans up a minor memory leak if a backend was specified and then gets unloaded.) Link: https://lore.kernel.org/lkml/20200510202436.63222-3-keescook@chromium.org/ Signed-off-by:

Kees Cook <keescook@chromium.org>

fs/pstore/platform.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -624,7 +624,7 @@ int pstore_register(struct pstore_info *psi)
		* Update the module parameter backend, so it is visible
		* through /sys/module/pstore/parameters/backend
		*/
		backend = psi->name;
		backend = kstrdup(psi->name, GFP_KERNEL);

		pr_info("Registered %s as persistent store backend\n", psi->name);

		@@ -667,6 +667,7 @@ void pstore_unregister(struct pstore_info *psi)
		free_buf_for_compression();

		psinfo = NULL;
		kfree(backend);
		backend = NULL;
		mutex_unlock(&psinfo_lock);
		}

include/linux/pstore.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -170,7 +170,7 @@ struct pstore_record {
		*/
		struct pstore_info {
		struct module *owner;
		char *name;
		const char *name;

		struct semaphore buf_lock;
		char *buf;

Admin message