Commit 55ff2324 authored by Vladimir Zapolskiy's avatar Vladimir Zapolskiy
Browse files

ARM: dts: lpc32xx: phy3250: remove regulators umbrella device node 



The originally added 'regulators' device node has a number of flaws,
to name a few its children has unit addresses but no reg properties,
the regulators are not captured by a device driver due to a missing
'simple-bus' compatible, the regulator names are selected by killing
either alphabetical order or device node grouping property.

The change removes 'regulators' device node and renames the regulators
and labels.

Signed-off-by: default avatarVladimir Zapolskiy <vz@mleia.com>
parent dc141b99

arch/arm/boot/dts/lpc3250-phy3250.dts

+31 −32
Original line number Diff line number Diff line
@@ -25,10 +25,23 @@ 
		reg = <0x80000000 0x4000000>;

	};



	regulators {

		backlight_reg: regulator@0 {

	leds {

		compatible = "gpio-leds";



		led0 { /* red */

			gpios = <&gpio 5 1 0>; /* GPO_P3 1, GPIO 80, active high */

			default-state = "off";

		};



		led1 { /* green */

			gpios = <&gpio 5 14 0>; /* GPO_P3 14, GPIO 93, active high */

			linux,default-trigger = "heartbeat";

		};

	};



	reg_backlight: regulator-backlight {

		compatible = "regulator-fixed";

			regulator-name = "backlight_reg";

		regulator-name = "backlight";

		regulator-min-microvolt = <1800000>;

		regulator-max-microvolt = <1800000>;

		gpio = <&gpio 5 4 0>;
@@ -36,9 +49,9 @@ 
		regulator-boot-on;

	};



		lcd_reg: regulator@1 {

	reg_lcd: regulator-lcd {

		compatible = "regulator-fixed";

			regulator-name = "lcd_reg";

		regulator-name = "lcd";

		regulator-min-microvolt = <1800000>;

		regulator-max-microvolt = <1800000>;

		gpio = <&gpio 5 0 0>;
@@ -46,28 +59,14 @@ 
		regulator-boot-on;

	};



		sd_reg: regulator@2 {

	reg_sd: regulator-sd {

		compatible = "regulator-fixed";

			regulator-name = "sd_reg";

		regulator-name = "sd";

		regulator-min-microvolt = <3300000>;

		regulator-max-microvolt = <3300000>;

		gpio = <&gpio 5 5 0>;

		enable-active-high;

		};

	};



	leds {

		compatible = "gpio-leds";



		led0 { /* red */

			gpios = <&gpio 5 1 0>; /* GPO_P3 1, GPIO 80, active high */

			default-state = "off";

		};



		led1 { /* green */

			gpios = <&gpio 5 14 0>; /* GPO_P3 14, GPIO 93, active high */

			linux,default-trigger = "heartbeat";

		};

		regulator-boot-on;

	};

};
@@ -130,7 +129,7 @@ 
	cd-gpios = <&gpio 3 1 0>;

	cd-inverted;

	bus-width = <4>;

	vmmc-supply = <&sd_reg>;

	vmmc-supply = <&reg_sd>;

	status = "okay";

};

CRA Git | Maintained and supported by SUSTech CRA and CCSE