Commit 55f9a070 authored Sep 15, 2015 by Jarkko Nikula Committed by Mark Brown Sep 17, 2015

spi: dw: Remove test for non-zero spi->max_speed_hz

Test for non-zero spi->max_speed_hz in dw_spi_setup() looks needless as
spi_setup() defaults to master->max_speed_hz in case it is not set. This
drivers sets the master->max_speed_hz based on max_freq data passed to it
via dw_spi_add_host() call. I suppose things have already fallen apart if
dw_spi_mmio_probe() or spi_pci_probe() ever passes zero max_freq.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 0ed36990

drivers/spi/spi-dw.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -448,11 +448,6 @@ static int dw_spi_setup(struct spi_device *spi)
		}
		chip->bits_per_word = spi->bits_per_word;

		if (!spi->max_speed_hz) {
		dev_err(&spi->dev, "No max speed HZ parameter\n");
		return -EINVAL;
		}

		chip->tmode = 0; /* Tx & Rx */
		/* Default SPI mode is SCPOL = 0, SCPH = 0 */
		chip->cr0 = (chip->bits_per_word - 1)

Admin message