Commit 55f8b254 authored Sep 12, 2020 by Barry Song Committed by Vinod Koul Sep 18, 2020

dmaengine: zx: remove redundant irqsave in hardIRQ



Running in hardIRQ context, disabling IRQ is redundant.

Cc: Jun Nie <jun.nie@linaro.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Link: https://lore.kernel.org/r/20200912094036.32112-1-song.bao.hua@hisilicon.com


Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent e3a52158

drivers/dma/zx_dma.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -285,9 +285,7 @@ static irqreturn_t zx_dma_int_handler(int irq, void *dev_id)
		p = &d->phy[i];
		c = p->vchan;
		if (c) {
		unsigned long flags;

		spin_lock_irqsave(&c->vc.lock, flags);
		spin_lock(&c->vc.lock);
		if (c->cyclic) {
		vchan_cyclic_callback(&p->ds_run->vd);
		} else {
		@@ -295,7 +293,7 @@ static irqreturn_t zx_dma_int_handler(int irq, void *dev_id)
		p->ds_done = p->ds_run;
		task = 1;
		}
		spin_unlock_irqrestore(&c->vc.lock, flags);
		spin_unlock(&c->vc.lock);
		irq_chan \|= BIT(i);
		}
		}

Admin message