Commit 55f3952d authored Jun 25, 2007 by Tejun Heo Committed by Jeff Garzik Jun 27, 2007

libata: kill the infamous abnormal status message



The infamous abnormal status message triggers on not so abnormal cases
including empty port and even when it's being triggered on actual
errors the info it provides is redundant and out of context - higher
level functions will print the info in better safe later anyway.

Also, by being triggered all the time, it leads people to think that
the abnormality is somehow related to all ATA and system problems
they're experiencing and gives owners of healthy systems unfounded
doubts about the integrity of the universe.  Make it a DPRINTK and
save the universe.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

parent 62877f6b

include/linux/libata.h

+3 −5

Original line number	Diff line number	Diff line
		@@ -1088,11 +1088,9 @@ static inline u8 ata_wait_idle(struct ata_port *ap)
		{
		u8 status = ata_busy_wait(ap, ATA_BUSY \| ATA_DRQ, 1000);

		if (status != 0xff && (status & (ATA_BUSY \| ATA_DRQ))) {
		if (ata_msg_warn(ap))
		printk(KERN_WARNING "ATA: abnormal status 0x%X on port 0x%p\n",
		if (status != 0xff && (status & (ATA_BUSY \| ATA_DRQ)))
		DPRINTK("ATA: abnormal status 0x%X on port 0x%p\n",
		status, ap->ioaddr.status_addr);
		}

		return status;
		}

Admin message