Commit 55e858b7 authored Jan 11, 2015 by Marc Zyngier Committed by Paolo Bonzini Jan 12, 2015

arm64: KVM: Fix TLB invalidation by IPA/VMID



It took about two years for someone to notice that the IPA passed
to TLBI IPAS2E1IS must be shifted by 12 bits. Clearly our reviewing
is not as good as it should be...

Paper bag time for me.

Reported-by: Mario Smarduch <m.smarduch@samsung.com>
Tested-by: Mario Smarduch <m.smarduch@samsung.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent b1940cd2

arch/arm64/kvm/hyp.S

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -1014,6 +1014,7 @@ ENTRY(__kvm_tlb_flush_vmid_ipa)
	* Instead, we invalidate Stage-2 for this IPA, and the		* Instead, we invalidate Stage-2 for this IPA, and the
	* whole of Stage-1. Weep...		* whole of Stage-1. Weep...
	*/		*/
			lsr x1, x1, #12
	tlbi ipas2e1is, x1		tlbi ipas2e1is, x1
	/*		/*
	* We have to ensure completion of the invalidation at Stage-2,		* We have to ensure completion of the invalidation at Stage-2,

Admin message