Commit 55e3a601 authored by Zhaolei's avatar Zhaolei Committed by Chris Mason
Browse files

btrfs: Fix data checksum error cause by replace with io-load. 



xfstests btrfs/070 sometimes failed.
In my test machine, its fail rate is about 30%.
In another vm(vmware), its fail rate is about 50%.

Reason:
  btrfs/070 do replace and defrag with fsstress simultaneously,
  after above operation, checksum error is found by scrub.

  Actually, it have no relationship with defrag operation, only
  replace with fsstress can trigger this bug.

  New data writen to target device have possibility rewrited by
  old data from source device by replace code in debug, to avoid
  above problem, we can set target block group to readonly in
  replace period, so new data requested by other operation will
  not write to same place with replace code.

  Before patch(4.1-rc3):
    30% failed in 100 xfstests.
  After patch:
    0% failed in 300 xfstests.

It also happened in btrfs/071 as it's another scrub with IO load tests.

Reported-by: default avatarQu Wenruo <quwenruo@cn.fujitsu.com>
Signed-off-by: default avatarQu Wenruo <quwenruo@cn.fujitsu.com>
Signed-off-by: default avatarZhao Lei <zhaolei@cn.fujitsu.com>
Signed-off-by: default avatarChris Mason <clm@fb.com>
parent b708ce96

fs/btrfs/scrub.c

+27 −7
Original line number Original line Diff line number Diff line
@@ -3407,7 +3407,7 @@ int scrub_enumerate_chunks(struct scrub_ctx *sctx, 
	u64 chunk_tree;

	u64 chunk_tree;

	u64 chunk_objectid;

	u64 chunk_objectid;

	u64 chunk_offset;

	u64 chunk_offset;

	int ret;

	int ret = 0;

	int slot;

	int slot;

	struct extent_buffer *l;

	struct extent_buffer *l;

	struct btrfs_key key;

	struct btrfs_key key;
@@ -3435,9 +3435,15 @@ int scrub_enumerate_chunks(struct scrub_ctx *sctx, 
			if (path->slots[0] >=

			if (path->slots[0] >=

			    btrfs_header_nritems(path->nodes[0])) {

			    btrfs_header_nritems(path->nodes[0])) {

				ret = btrfs_next_leaf(root, path);

				ret = btrfs_next_leaf(root, path);

				if (ret)

				if (ret < 0)

					break;

				if (ret > 0) {

					ret = 0;

					break;

					break;

				}

				}

			} else {

				ret = 0;

			}

		}

		}





		l = path->nodes[0];

		l = path->nodes[0];
@@ -3478,6 +3484,22 @@ int scrub_enumerate_chunks(struct scrub_ctx *sctx, 
		if (!cache)

		if (!cache)

			goto skip;

			goto skip;





		/*

		 * we need call btrfs_inc_block_group_ro() with scrubs_paused,

		 * to avoid deadlock caused by:

		 * btrfs_inc_block_group_ro()

		 * -> btrfs_wait_for_commit()

		 * -> btrfs_commit_transaction()

		 * -> btrfs_scrub_pause()

		 */

		scrub_pause_on(fs_info);

		ret = btrfs_inc_block_group_ro(root, cache);

		scrub_pause_off(fs_info);

		if (ret) {

			btrfs_put_block_group(cache);

			break;

		}



		dev_replace->cursor_right = found_key.offset + length;

		dev_replace->cursor_right = found_key.offset + length;

		dev_replace->cursor_left = found_key.offset;

		dev_replace->cursor_left = found_key.offset;

		dev_replace->item_needs_writeback = 1;

		dev_replace->item_needs_writeback = 1;
@@ -3517,6 +3539,8 @@ int scrub_enumerate_chunks(struct scrub_ctx *sctx, 




		scrub_pause_off(fs_info);

		scrub_pause_off(fs_info);





		btrfs_dec_block_group_ro(root, cache);



		btrfs_put_block_group(cache);

		btrfs_put_block_group(cache);

		if (ret)

		if (ret)

			break;

			break;
@@ -3539,11 +3563,7 @@ skip: 




	btrfs_free_path(path);

	btrfs_free_path(path);





	/*

	return ret;

	 * ret can still be 1 from search_slot or next_leaf,

	 * that's not an error

	 */

	return ret < 0 ? ret : 0;

}

}





static noinline_for_stack int scrub_supers(struct scrub_ctx *sctx,

static noinline_for_stack int scrub_supers(struct scrub_ctx *sctx,

fs/btrfs/volumes.c

+2 −0
Original line number Original line Diff line number Diff line
@@ -2785,7 +2785,9 @@ static int btrfs_relocate_chunk(struct btrfs_root *root, 
		return -ENOSPC;

		return -ENOSPC;





	/* step one, relocate all the extents inside this chunk */

	/* step one, relocate all the extents inside this chunk */

	btrfs_scrub_pause(root);

	ret = btrfs_relocate_block_group(extent_root, chunk_offset);

	ret = btrfs_relocate_block_group(extent_root, chunk_offset);

	btrfs_scrub_continue(root);

	if (ret)

	if (ret)

		return ret;

		return ret;

CRA Git | Maintained and supported by SUSTech CRA and CCSE