Commit 55dd5758 authored Feb 17, 2020 by Karsten Graul Committed by David S. Miller Feb 17, 2020

net/smc: improve smc_lgr_cleanup()



smc_lgr_cleanup() is called during termination processing, there is no
need to send a DELETE_LINK at that time. A DELETE_LINK should have been
sent before the termination is initiated, if needed.
And remove the extra call to wake_up(&lnk->wr_reg_wait) because
smc_llc_link_inactive() already calls the related helper function
smc_wr_wakeup_reg_wait().

Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 790a9a7c

net/smc/smc_core.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -576,13 +576,10 @@ static void smc_lgr_cleanup(struct smc_link_group *lgr)
		} else {
		struct smc_link *lnk = &lgr->lnk[SMC_SINGLE_LINK];

		wake_up(&lnk->wr_reg_wait);
		if (lnk->state != SMC_LNK_INACTIVE) {
		smc_link_send_delete(lnk, false);
		if (lnk->state != SMC_LNK_INACTIVE)
		smc_llc_link_inactive(lnk);
		}
		}
		}

		/* terminate link group */
		static void __smc_lgr_terminate(struct smc_link_group *lgr, bool soft)

Admin message