Commit 55cd7386 authored by Sasha Neftin's avatar Sasha Neftin Committed by Jeff Kirsher
Browse files

igc: Remove no need declaration of the igc_write_itr 



We want to avoid forward-declarations of function if possible.
Rearrange the igc_write_itr function implementation.

Signed-off-by: default avatarSasha Neftin <sasha.neftin@intel.com>
Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent f817fa05

drivers/net/ethernet/intel/igc/igc_main.c

+16 −17
Original line number Diff line number Diff line
@@ -53,7 +53,6 @@ MODULE_DEVICE_TABLE(pci, igc_pci_tbl); 


/* forward declaration */

static int igc_sw_init(struct igc_adapter *);

static void igc_write_itr(struct igc_q_vector *q_vector);



enum latency_range {

	lowest_latency = 0,
@@ -2931,6 +2930,22 @@ static irqreturn_t igc_msix_other(int irq, void *data) 
	return IRQ_HANDLED;

}



static void igc_write_itr(struct igc_q_vector *q_vector)

{

	u32 itr_val = q_vector->itr_val & IGC_QVECTOR_MASK;



	if (!q_vector->set_itr)

		return;



	if (!itr_val)

		itr_val = IGC_ITR_VAL_MASK;



	itr_val |= IGC_EITR_CNT_IGNR;



	writel(itr_val, q_vector->itr_register);

	q_vector->set_itr = 0;

}



static irqreturn_t igc_msix_ring(int irq, void *data)

{

	struct igc_q_vector *q_vector = data;
@@ -4044,22 +4059,6 @@ request_done: 
	return err;

}



static void igc_write_itr(struct igc_q_vector *q_vector)

{

	u32 itr_val = q_vector->itr_val & IGC_QVECTOR_MASK;



	if (!q_vector->set_itr)

		return;



	if (!itr_val)

		itr_val = IGC_ITR_VAL_MASK;



	itr_val |= IGC_EITR_CNT_IGNR;



	writel(itr_val, q_vector->itr_register);

	q_vector->set_itr = 0;

}



/**

 * __igc_open - Called when a network interface is made active

 * @netdev: network interface device structure

CRA Git | Maintained and supported by SUSTech CRA and CCSE