Commit 55cae7a4 authored Aug 08, 2016 by Arnd Bergmann Committed by David Howells Aug 09, 2016

rxrpc: fix uninitialized pointer dereference in debug code



A newly added bugfix caused an uninitialized variable to be
used for printing debug output. This is harmless as long
as the debug setting is disabled, but otherwise leads to an
immediate crash.

gcc warns about this when -Wmaybe-uninitialized is enabled:

net/rxrpc/call_object.c: In function 'rxrpc_release_call':
net/rxrpc/call_object.c:496:163: error: 'sp' may be used uninitialized in this function [-Werror=maybe-uninitialized]

The initialization was removed but one of the users remains.
This adds back the initialization.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 372ee163 ("rxrpc: Fix races between skb free, ACK generation and replying")
Signed-off-by: David Howells <dhowells@redhat.com>

parent 1fe323aa

net/rxrpc/call_object.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -493,6 +493,7 @@ void rxrpc_release_call(struct rxrpc_call *call)
		(skb = skb_dequeue(&call->rx_oos_queue))) {
		spin_unlock_bh(&call->lock);

		sp = rxrpc_skb(skb);
		_debug("- zap %s %%%u #%u",
		rxrpc_pkts[sp->hdr.type],
		sp->hdr.serial, sp->hdr.seq);

Admin message