Commit 55ca3e79 authored by WANG Cong's avatar WANG Cong Committed by Linus Torvalds
Browse files

fs/romfs/inode.c: trivial improvements 



- There are no lists in fs/romfs/inode.c, so using list_entry
  is a bit confusing.  Replace it with container_of.

- It is unnecessary to cast the return value of
  kmem_cache_alloc, since it returns a void* pointer.

Signed-off-by: default avatarWANG Cong <xiyou.wangcong@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0cbc591b

fs/romfs/inode.c

+2 −2
Original line number Diff line number Diff line
@@ -92,7 +92,7 @@ static inline unsigned long romfs_maxsize(struct super_block *sb) 


static inline struct romfs_inode_info *ROMFS_I(struct inode *inode)

{

	return list_entry(inode, struct romfs_inode_info, vfs_inode);

	return container_of(inode, struct romfs_inode_info, vfs_inode);

}



static __u32
@@ -555,7 +555,7 @@ static struct kmem_cache * romfs_inode_cachep; 
static struct inode *romfs_alloc_inode(struct super_block *sb)

{

	struct romfs_inode_info *ei;

	ei = (struct romfs_inode_info *)kmem_cache_alloc(romfs_inode_cachep, GFP_KERNEL);

	ei = kmem_cache_alloc(romfs_inode_cachep, GFP_KERNEL);

	if (!ei)

		return NULL;

	return &ei->vfs_inode;

CRA Git | Maintained and supported by SUSTech CRA and CCSE