mmc: dw_mmc: handle "no CRC status" error (55c5efbc) · Commits · 戴 / test

When a data write isn't acknowledged by the card (so no CRC status token is detected after the data), the error -EIO is returned instead of the -ETIMEDOUT expected by mmc_test 15 - "Correct xfer_size at write (start failure)" and 17 "Correct xfer_size at write (midway failure)". In PIO mode the reported number of bytes transferred is also exaggerated since the last block actually failed. Handle the "Write no CRC" error specially, setting the error to -ETIMEDOUT and setting the bytes_xferred to 0. Signed-off-by:

James Hogan <james.hogan@imgtec.com> Acked-by:

Will Newton <will.newton@imgtec.com> Tested-by:

Jaehoon Chung <jh80.chung@samsung.com> Signed-off-by:

Chris Ball <cjb@laptop.org>

drivers/mmc/host/dw_mmc.c

+15 −4

Original line number	Diff line number	Diff line
		@@ -496,15 +496,16 @@ static void dw_mci_submit_data(struct dw_mci host, struct mmc_data data)
		host->sg = NULL;
		host->data = data;

		if (data->flags & MMC_DATA_READ)
		host->dir_status = DW_MCI_RECV_STATUS;
		else
		host->dir_status = DW_MCI_SEND_STATUS;

		if (dw_mci_submit_data_dma(host, data)) {
		host->sg = data->sg;
		host->pio_offset = 0;
		host->part_buf_start = 0;
		host->part_buf_count = 0;
		if (data->flags & MMC_DATA_READ)
		host->dir_status = DW_MCI_RECV_STATUS;
		else
		host->dir_status = DW_MCI_SEND_STATUS;

		mci_writel(host, RINTSTS, SDMMC_INT_TXDR \| SDMMC_INT_RXDR);
		temp = mci_readl(host, INTMASK);
		@@ -911,6 +912,16 @@ static void dw_mci_tasklet_func(unsigned long priv)
		data->error = -ETIMEDOUT;
		} else if (status & SDMMC_INT_DCRC) {
		data->error = -EILSEQ;
		} else if (status & SDMMC_INT_EBE &&
		host->dir_status ==
		DW_MCI_SEND_STATUS) {
		/*
		* No data CRC status was returned.
		* The number of bytes transferred will
		* be exaggerated in PIO mode.
		*/
		data->bytes_xfered = 0;
		data->error = -ETIMEDOUT;
		} else {
		dev_err(&host->pdev->dev,
		"data FIFO error "

Admin message