maiblox: mediatek: Fix handling of platform_get_irq() error (558e4c36) · Commits · 戴 / test

platform_get_irq() returns -ERRNO on error. In such case casting to u32 and comparing to 0 would pass the check. Fixes: ("mailbox: mediatek: Add Mediatek CMDQ driver") Signed-off-by:

Krzysztof Kozlowski <krzk@kernel.org> Signed-off-by:

Jassi Brar <jaswinder.singh@linaro.org>

drivers/mailbox/mtk-cmdq-mailbox.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -69,7 +69,7 @@ struct cmdq_task {
		struct cmdq {
		struct mbox_controller mbox;
		void __iomem *base;
		u32 irq;
		int irq;
		u32 thread_nr;
		u32 irq_mask;
		struct cmdq_thread *thread;
		@@ -525,10 +525,8 @@ static int cmdq_probe(struct platform_device *pdev)
		}

		cmdq->irq = platform_get_irq(pdev, 0);
		if (!cmdq->irq) {
		dev_err(dev, "failed to get irq\n");
		return -EINVAL;
		}
		if (cmdq->irq < 0)
		return cmdq->irq;

		plat_data = (struct gce_plat *)of_device_get_match_data(dev);
		if (!plat_data) {

Admin message