Commit 557c0315 authored Jan 16, 2020 by YueHaibing Committed by Ulf Hansson Jan 20, 2020

mmc: sdhci-milbeaut: Remove redundant platform_get_irq error message



platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20200116144322.57308-1-yuehaibing@huawei.com


Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent 1215c025

drivers/mmc/host/sdhci-milbeaut.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -246,10 +246,8 @@ static int sdhci_milbeaut_probe(struct platform_device *pdev)
		struct f_sdhost_priv *priv;

		irq = platform_get_irq(pdev, 0);
		if (irq < 0) {
		dev_err(dev, "%s: no irq specified\n", __func__);
		if (irq < 0)
		return irq;
		}

		host = sdhci_alloc_host(dev, sizeof(struct f_sdhost_priv));
		if (IS_ERR(host))

Admin message