Commit 553b0c64 authored Apr 21, 2018 by Miquel Raynal Committed by Boris Brezillon Apr 29, 2018

mtd: rawnand: lpc32xx_slc: fix the probe function error path



An error after nand_scan_tail() should trigger a nand_cleanup() and not
a nand_release(). The latter doing an mtd_device_unregister() which is
not needed if mtd_device_register() failed.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>

parent e0ea20bf

drivers/mtd/nand/raw/lpc32xx_slc.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -926,12 +926,12 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
		res = mtd_device_register(mtd, host->ncfg->parts,
		host->ncfg->num_parts);
		if (res)
		goto release_nand;
		goto cleanup_nand;

		return 0;

		release_nand:
		nand_release(mtd);
		cleanup_nand:
		nand_cleanup(chip);
		release_dma:
		dma_release_channel(host->dma_chan);
		unprepare_clk:

Admin message