Commit 55347ec3 authored Dec 19, 2019 by Yuya Fujita Committed by Arnaldo Carvalho de Melo Dec 20, 2019

perf hists: Fix variable name's inconsistency in hists__for_each() macro

Variable names are inconsistent in hists__for_each macro().

Due to this inconsistency, the macro replaces its second argument with
"fmt" regardless of its original name.

So far it works because only "fmt" is passed to the second argument.
However, this behavior is not expected and should be fixed.

Fixes: f0786af5 ("perf hists: Introduce hists__for_each_format macro")
Fixes: aa6f50af ("perf hists: Introduce hists__for_each_sort_list macro")
Signed-off-by: Yuya Fujita <fujita.yuya@fujitsu.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/OSAPR01MB1588E1C47AC22043175DE1B2E8520@OSAPR01MB1588.jpnprd01.prod.outlook.com

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent a75af86b

tools/perf/util/hist.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -339,10 +339,10 @@ static inline void perf_hpp__prepend_sort_field(struct perf_hpp_fmt *format)
		list_for_each_entry_safe(format, tmp, &(_list)->sorts, sort_list)

		#define hists__for_each_format(hists, format) \
		perf_hpp_list__for_each_format((hists)->hpp_list, fmt)
		perf_hpp_list__for_each_format((hists)->hpp_list, format)

		#define hists__for_each_sort_list(hists, format) \
		perf_hpp_list__for_each_sort_list((hists)->hpp_list, fmt)
		perf_hpp_list__for_each_sort_list((hists)->hpp_list, format)

		extern struct perf_hpp_fmt perf_hpp__format[];