Commit 553222f3 authored by Don Zickus's avatar Don Zickus Committed by Ingo Molnar
Browse files

x86/nmi: Add new NMI queues to deal with IO_CHK and SERR 



In discussions with Thomas Mingarelli about hpwdt, he explained
to me some issues they were some when using their virtual NMI
button to test the hpwdt driver.

It turns out the virtual NMI button used on HP's machines do no
send unknown NMIs but instead send IO_CHK NMIs.  The way the
kernel code is written, the hpwdt driver can not register itself
against that type of NMI and therefore can not successfully
capture system information before panic'ing.

To solve this I created two new NMI queues to allow driver to
register against the IO_CHK and SERR NMIs.  Or in the hpwdt all
three (if you include unknown NMIs too).

The change is straightforward and just mimics what the unknown
NMI does.

Reported-and-tested-by: default avatarThomas Mingarelli <thomas.mingarelli@hp.com>
Signed-off-by: default avatarDon Zickus <dzickus@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/1333051877-15755-3-git-send-email-dzickus@redhat.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 09ee1014

arch/x86/include/asm/nmi.h

+2 −0
Original line number Diff line number Diff line
@@ -27,6 +27,8 @@ void arch_trigger_all_cpu_backtrace(void); 
enum {

	NMI_LOCAL=0,

	NMI_UNKNOWN,

	NMI_SERR,

	NMI_IO_CHECK,

	NMI_MAX

};

arch/x86/kernel/nmi.c

+18 −0
Original line number Diff line number Diff line
@@ -54,6 +54,14 @@ static struct nmi_desc nmi_desc[NMI_MAX] = 
		.lock = __SPIN_LOCK_UNLOCKED(&nmi_desc[1].lock),

		.head = LIST_HEAD_INIT(nmi_desc[1].head),

	},

	{

		.lock = __SPIN_LOCK_UNLOCKED(&nmi_desc[2].lock),

		.head = LIST_HEAD_INIT(nmi_desc[2].head),

	},

	{

		.lock = __SPIN_LOCK_UNLOCKED(&nmi_desc[3].lock),

		.head = LIST_HEAD_INIT(nmi_desc[3].head),

	},



};
@@ -120,6 +128,8 @@ static int __setup_nmi(unsigned int type, struct nmiaction *action) 
	 * to manage expectations

	 */

	WARN_ON_ONCE(type == NMI_UNKNOWN && !list_empty(&desc->head));

	WARN_ON_ONCE(type == NMI_SERR && !list_empty(&desc->head));

	WARN_ON_ONCE(type == NMI_IO_CHECK && !list_empty(&desc->head));



	/*

	 * some handlers need to be executed first otherwise a fake
@@ -212,6 +222,10 @@ EXPORT_SYMBOL_GPL(unregister_nmi_handler); 
static notrace __kprobes void

pci_serr_error(unsigned char reason, struct pt_regs *regs)

{

	/* check to see if anyone registered against these types of errors */

	if (nmi_handle(NMI_SERR, regs, false))

		return;



	pr_emerg("NMI: PCI system error (SERR) for reason %02x on CPU %d.\n",

		 reason, smp_processor_id());
@@ -241,6 +255,10 @@ io_check_error(unsigned char reason, struct pt_regs *regs) 
{

	unsigned long i;



	/* check to see if anyone registered against these types of errors */

	if (nmi_handle(NMI_IO_CHECK, regs, false))

		return;



	pr_emerg(

	"NMI: IOCK error (debug interrupt?) for reason %02x on CPU %d.\n",

		 reason, smp_processor_id());

drivers/watchdog/hpwdt.c

+20 −7
Original line number Diff line number Diff line
@@ -725,19 +725,32 @@ static int __devinit hpwdt_init_nmi_decoding(struct pci_dev *dev) 
	 * Only one function can register for NMI_UNKNOWN

	 */

	retval = register_nmi_handler(NMI_UNKNOWN, hpwdt_pretimeout, 0, "hpwdt");

	if (retval != 0) {

		dev_warn(&dev->dev,

			"Unable to register a die notifier (err=%d).\n",

			retval);

		if (cru_rom_addr)

			iounmap(cru_rom_addr);

	}

	if (retval)

		goto error;

	retval = register_nmi_handler(NMI_SERR, hpwdt_pretimeout, 0, "hpwdt");

	if (retval)

		goto error1;

	retval = register_nmi_handler(NMI_IO_CHECK, hpwdt_pretimeout, 0, "hpwdt");

	if (retval)

		goto error2;



	dev_info(&dev->dev,

			"HP Watchdog Timer Driver: NMI decoding initialized"

			", allow kernel dump: %s (default = 0/OFF)\n",

			(allow_kdump == 0) ? "OFF" : "ON");

	return 0;



error2:

	unregister_nmi_handler(NMI_SERR, "hpwdt");

error1:

	unregister_nmi_handler(NMI_UNKNOWN, "hpwdt");

error:

	dev_warn(&dev->dev,

		"Unable to register a die notifier (err=%d).\n",

		retval);

	if (cru_rom_addr)

		iounmap(cru_rom_addr);

	return retval;

}



static void hpwdt_exit_nmi_decoding(void)

CRA Git | Maintained and supported by SUSTech CRA and CCSE