Commit 5512eb06 authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (sht21) Use permission specific SENSOR[_DEVICE]_ATTR variants 

Use SENSOR[_DEVICE]_ATTR[_2]_{RO,RW,WO} to simplify the source code,
to improve readability, and to reduce the chance of inconsistencies.

Also replace any remaining S_<PERMS> in the driver with octal values.

The conversion was done automatically with coccinelle. The semantic patches
and the scripts used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches/hwmon/

.

This patch does not introduce functional changes. It was verified by
compiling the old and new files and comparing text and data sizes.

Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 41c9a49a

drivers/hwmon/sht21.c

+7 −10
Original line number Diff line number Diff line
@@ -135,7 +135,7 @@ out: 
 * Will be called on read access to temp1_input sysfs attribute.

 * Returns number of bytes written into buffer, negative errno on error.

 */

static ssize_t sht21_show_temperature(struct device *dev,

static ssize_t sht21_temperature_show(struct device *dev,

				      struct device_attribute *attr,

				      char *buf)

{
@@ -157,9 +157,8 @@ static ssize_t sht21_show_temperature(struct device *dev, 
 * Will be called on read access to humidity1_input sysfs attribute.

 * Returns number of bytes written into buffer, negative errno on error.

 */

static ssize_t sht21_show_humidity(struct device *dev,

	struct device_attribute *attr,

	char *buf)

static ssize_t sht21_humidity_show(struct device *dev,

				   struct device_attribute *attr, char *buf)

{

	struct sht21 *sht21 = dev_get_drvdata(dev);

	int ret;
@@ -251,10 +250,8 @@ static ssize_t eic_show(struct device *dev, 
}



/* sysfs attributes */

static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, sht21_show_temperature,

	NULL, 0);

static SENSOR_DEVICE_ATTR(humidity1_input, S_IRUGO, sht21_show_humidity,

	NULL, 0);

static SENSOR_DEVICE_ATTR_RO(temp1_input, sht21_temperature, 0);

static SENSOR_DEVICE_ATTR_RO(humidity1_input, sht21_humidity, 0);

static DEVICE_ATTR_RO(eic);



static struct attribute *sht21_attrs[] = {

CRA Git | Maintained and supported by SUSTech CRA and CCSE