Commit 5509ac65 authored Jun 14, 2020 by Navid Emamdoost Committed by Alex Deucher Jul 01, 2020

drm/amd/display: fix ref count leak in amdgpu_drm_ioctl



in amdgpu_drm_ioctl the call to pm_runtime_get_sync increments the
counter even in case of failure, leading to incorrect
ref count. In case of failure, decrement the ref count before returning.

Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent 9ba8923c

drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1383,11 +1383,12 @@ long amdgpu_drm_ioctl(struct file *filp,
		dev = file_priv->minor->dev;
		ret = pm_runtime_get_sync(dev->dev);
		if (ret < 0)
		return ret;
		goto out;

		ret = drm_ioctl(filp, cmd, arg);

		pm_runtime_mark_last_busy(dev->dev);
		out:
		pm_runtime_put_autosuspend(dev->dev);
		return ret;
		}

Admin message